Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused "InsufficientPrivilege" NOCResponse status #21124

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Remove unused "InsufficientPrivilege" NOCResponse status #21124

merged 1 commit into from
Jul 25, 2022

Conversation

woody-apple
Copy link
Contributor

Problem

In #20849 we fixed IM handling of fabric-scoped commands over PASE.

Even though it's not longer used, there are bits of InsufficientPrivilege NOCResponse
status left.

Fixes #20811

Change overview

This PR removes unused InsufficientPrivilege NOCResponse

Testing

  • Unit tests still pass
  • Integration tests still pass
  • Remove code paths are unreachable otherwise

@tcarmelveilleux @restyled-commits @web-flow
Remove unused "InsufficientPrivilege" NOCResponse status (#21072)
2696b93 
* Remove InsufficientPrivilege no longer used

* ZAP regen

* Zap regen

* Regen zap

* Restyled by clang-format

Co-authored-by: Restyled.io <[email protected]>
@github-actions
Copy link

github-actions bot commented Jul 22, 2022 •
edited
Loading

PR #21124: Size comparison from bcdfbfa to 2696b93

Increases (6 builds for cc13x2_26x2)
platform target config section bcdfbfa 2696b93 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 183144 183216 72 0.0
lock-ftd LP_CC2652R7 (read/write) 170228 170300 72 0.0
lock-mtd LP_CC2652R7 (read/write) 183632 183696 64 0.0
pump-app LP_CC2652R7 (read/write) 161600 161664 64 0.0
pump-controller-app LP_CC2652R7 (read/write) 175944 176000 56 0.0
shell LP_CC2652R7 (read/write) 186172 186228 56 0.0
Decreases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section bcdfbfa 2696b93 change % change
bl602 lighting-app bl602 (read/write) 1380538 1380466 -72 -0.0
.text 1050676 1050624 -52 -0.0
bl602+rpc (read/write) 1425978 1425898 -80 -0.0
.text 1082364 1082308 -56 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668199 668127 -72 -0.0
.rodata 88327 88303 -24 -0.0
.text 579556 579508 -48 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633791 633735 -56 -0.0
.rodata 77551 77527 -24 -0.0
.text 555916 555884 -32 -0.0
lock-ftd LP_CC2652R7 (read only) 671291 671219 -72 -0.0
.rodata 76443 76419 -24 -0.0
.text 594368 594320 -48 -0.0
lock-mtd LP_CC2652R7 (read only) 653575 653511 -64 -0.0
.rodata 101183 101159 -24 -0.0
.text 551912 551872 -40 -0.0
pump-app LP_CC2652R7 (read only) 680775 680711 -64 -0.0
.rodata 89039 89015 -24 -0.0
.text 591252 591212 -40 -0.0
pump-controller-app LP_CC2652R7 (read only) 666551 666495 -56 -0.0
.rodata 84895 84871 -24 -0.0
.text 581176 581144 -32 -0.0
shell LP_CC2652R7 (read only) 660674 660618 -56 -0.0
.rodata 85098 85074 -24 -0.0
.text 575260 575228 -32 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 581778 581706 -72 -0.0
.app_xip_area 460312 460240 -72 -0.0
lock cyw930739m2evb_01 (read/write) 587678 587614 -64 -0.0
.app_xip_area 461484 461420 -64 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 585974 585910 -64 -0.0
.app_xip_area 465356 465292 -64 -0.0
efr32 lighting-app BRD4161A (read/write) 1087424 1087352 -72 -0.0
.text 952136 952064 -72 -0.0
BRD4161A+rpc (read/write) 1141748 1141668 -80 -0.0
.text 989572 989492 -80 -0.0
BRD4161A+rs911x (read/write) 972604 972532 -72 -0.0
.text 808872 808800 -72 -0.0
lock-app BRD4161A+wf200 (read/write) 1127960 1127904 -56 -0.0
.text 981580 981524 -56 -0.0
window-app BRD4161A (read/write) 1080900 1080828 -72 -0.0
.text 944112 944040 -72 -0.0
esp32 all-clusters-app c3devkit (read only) 1022024 1021986 -38 -0.0
(read/write) 1486290 1486258 -32 -0.0
.flash.rodata 216016 215984 -32 -0.0
.flash.text 1022024 1021986 -38 -0.0
m5stack (read only) 1075743 1075703 -40 -0.0
(read/write) 488312 488288 -24 -0.0
.flash.rodata 246420 246396 -24 -0.0
.flash.text 1070359 1070319 -40 -0.0
k32w light k32w061+release (read/write) 660496 660424 -72 -0.0
.text 583036 582964 -72 -0.0
lock k32w061+release (read/write) 687500 687428 -72 -0.0
.text 609556 609484 -72 -0.0
linux all-clusters-app debug (read only) 2980537 2980297 -240 -0.0
.rodata 265739 265707 -32 -0.0
.text 2536658 2536450 -208 -0.0
all-clusters-minimal-app debug (read only) 2826433 2826177 -256 -0.0
.rodata 266603 266571 -32 -0.0
.text 2384370 2384146 -224 -0.0
bridge-app debug+rpc (read only) 2341153 2340897 -256 -0.0
.rodata 199240 199208 -32 -0.0
.text 1979602 1979378 -224 -0.0
chip-tool debug (read only) 10349249 10349217 -32 -0.0
.text 8373844 8373812 -32 -0.0
chip-tool-ipv6only arm64 (read only) 9778876 9778860 -16 -0.0
.text 7736900 7736884 -16 -0.0
lighting-app debug+rpc (read only) 2564289 2564033 -256 -0.0
.rodata 214832 214800 -32 -0.0
.text 2179058 2178834 -224 -0.0
lock-app debug (read only) 2529281 2529041 -240 -0.0
.rodata 229936 229904 -32 -0.0
.text 2133746 2133538 -208 -0.0
ota-provider-app debug (read only) 2332865 2332657 -208 -0.0
.text 1964930 1964722 -208 -0.0
ota-requestor-app debug (read only) 2451321 2451081 -240 -0.0
.rodata 208448 208416 -32 -0.0
.text 2071266 2071058 -208 -0.0
shell debug (read only) 2567161 2566905 -256 -0.0
.rodata 229042 229010 -32 -0.0
.text 2180562 2180338 -224 -0.0
thermostat-no-ble arm64 (read only) 2341052 2340764 -288 -0.0
(read/write) 141265 141249 -16 -0.0
.data.rel.ro 75616 75592 -24 -0.0
.rodata 139444 139412 -32 -0.0
.text 1964768 1964544 -224 -0.0
tv-app debug (read only) 3114913 3114641 -272 -0.0
.rodata 250440 250408 -32 -0.0
.text 2676050 2675810 -240 -0.0
tv-casting-app debug (read only) 5368625 5368385 -240 -0.0
.rodata 334625 334593 -32 -0.0
.text 4767474 4767266 -208 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2448968 2448936 -32 -0.0
.text 1411612 1411580 -32 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176959 1176887 -72 -0.0
rodata 142440 142416 -24 -0.0
text 812580 812540 -40 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157011 1156939 -72 -0.0
rodata 133972 133948 -24 -0.0
text 801892 801852 -40 -0.0
p6 all-clusters-app default (read/write) 1686564 1686492 -72 -0.0
.text 1526464 1526392 -72 -0.0
all-clusters-minimal-app default (read/write) 1630684 1630604 -80 -0.0
.text 1471304 1471224 -80 -0.0
light-app default (read/write) 1550716 1550644 -72 -0.0
.text 1399640 1399568 -72 -0.0
lock-app default (read/write) 1588308 1588236 -72 -0.0
.text 1432760 1432688 -72 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 799404 799328 -76 -0.0
text 567128 567078 -50 -0.0
lighting-app tlsr9518adk80d (read/write) 819452 819376 -76 -0.0
text 583672 583624 -48 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section bcdfbfa 2696b93 change % change
bl602 lighting-app bl602 (read/write) 1380538 1380466 -72 -0.0
.bss 117474 117474 0 0.0
.data 4480 4480 0 0.0
.text 1050676 1050624 -52 -0.0
bl602+rpc (read/write) 1425978 1425898 -80 -0.0
.bss 124922 124922 0 0.0
.data 4600 4600 0 0.0
.text 1082364 1082308 -56 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668199 668127 -72 -0.0
(read/write) 183144 183216 72 0.0
.bss 74236 74236 0 0.0
.data 3356 3356 0 0.0
.rodata 88327 88303 -24 -0.0
.text 579556 579508 -48 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633791 633735 -56 -0.0
(read/write) 157804 157804 0 0.0
.bss 73532 73532 0 0.0
.data 3356 3356 0 0.0
.rodata 77551 77527 -24 -0.0
.text 555916 555884 -32 -0.0
lock-ftd LP_CC2652R7 (read only) 671291 671219 -72 -0.0
(read/write) 170228 170300 72 0.0
.bss 71300 71300 0 0.0
.data 3280 3280 0 0.0
.rodata 76443 76419 -24 -0.0
.text 594368 594320 -48 -0.0
lock-mtd LP_CC2652R7 (read only) 653575 653511 -64 -0.0
(read/write) 183632 183696 64 0.0
.bss 66988 66988 0 0.0
.data 3280 3280 0 0.0
.rodata 101183 101159 -24 -0.0
.text 551912 551872 -40 -0.0
pump-app LP_CC2652R7 (read only) 680775 680711 -64 -0.0
(read/write) 161600 161664 64 0.0
.bss 71388 71388 0 0.0
.data 3280 3280 0 0.0
.rodata 89039 89015 -24 -0.0
.text 591252 591212 -40 -0.0
pump-controller-app LP_CC2652R7 (read only) 666551 666495 -56 -0.0
(read/write) 175944 176000 56 0.0
.bss 71508 71508 0 0.0
.data 3276 3276 0 0.0
.rodata 84895 84871 -24 -0.0
.text 581176 581144 -32 -0.0
shell LP_CC2652R7 (read only) 660674 660618 -56 -0.0
(read/write) 186172 186228 56 0.0
.bss 76540 76540 0 0.0
.data 3360 3360 0 0.0
.rodata 85098 85074 -24 -0.0
.text 575260 575228 -32 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 581778 581706 -72 -0.0
.app_xip_area 460312 460240 -72 -0.0
.bss 64404 64404 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587678 587614 -64 -0.0
.app_xip_area 461484 461420 -64 -0.0
.bss 69132 69132 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 585974 585910 -64 -0.0
.app_xip_area 465356 465292 -64 -0.0
.bss 63612 63612 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1087424 1087352 -72 -0.0
.bss 133220 133220 0 0.0
.data 2048 2048 0 0.0
.text 952136 952064 -72 -0.0
BRD4161A+rpc (read/write) 1141748 1141668 -80 -0.0
.bss 149892 149892 0 0.0
.data 2260 2260 0 0.0
.text 989572 989492 -80 -0.0
BRD4161A+rs911x (read/write) 972604 972532 -72 -0.0
.bss 161664 161664 0 0.0
.data 2048 2048 0 0.0
.text 808872 808800 -72 -0.0
lock-app BRD4161A+wf200 (read/write) 1127960 1127904 -56 -0.0
.bss 144304 144304 0 0.0
.data 2056 2056 0 0.0
.text 981580 981524 -56 -0.0
window-app BRD4161A (read/write) 1080900 1080828 -72 -0.0
.bss 134692 134692 0 0.0
.data 2076 2076 0 0.0
.text 944112 944040 -72 -0.0
esp32 all-clusters-app c3devkit (read only) 1022024 1021986 -38 -0.0
(read/write) 1486290 1486258 -32 -0.0
.dram0.bss 70232 70232 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216016 215984 -32 -0.0
.flash.text 1022024 1021986 -38 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075743 1075703 -40 -0.0
(read/write) 488312 488288 -24 -0.0
.dram0.bss 75752 75752 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246420 246396 -24 -0.0
.flash.text 1070359 1070319 -40 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 660496 660424 -72 -0.0
.bss 69668 69668 0 0.0
.data 1992 1992 0 0.0
.text 583036 582964 -72 -0.0
lock k32w061+release (read/write) 687500 687428 -72 -0.0
.bss 70140 70140 0 0.0
.data 2004 2004 0 0.0
.text 609556 609484 -72 -0.0
linux all-clusters-app debug (read only) 2980537 2980297 -240 -0.0
(read/write) 155344 155344 0 0.0
.bss 61792 61792 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 85224 85224 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 265739 265707 -32 -0.0
.text 2536658 2536450 -208 -0.0
all-clusters-minimal-app debug (read only) 2826433 2826177 -256 -0.0
(read/write) 147016 147016 0 0.0
.bss 60992 60992 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77784 77784 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 266603 266571 -32 -0.0
.text 2384370 2384146 -224 -0.0
bridge-app debug+rpc (read only) 2341153 2340897 -256 -0.0
(read/write) 126920 126920 0 0.0
.bss 50080 50080 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 67240 67240 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 199240 199208 -32 -0.0
.text 1979602 1979378 -224 -0.0
chip-tool debug (read only) 10349249 10349217 -32 -0.0
(read/write) 631912 631912 0 0.0
.bss 24760 24760 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 597480 597480 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 521813 521813 0 0.0
.text 8373844 8373812 -32 -0.0
chip-tool-ipv6only arm64 (read only) 9778876 9778860 -16 -0.0
(read/write) 679441 679441 0 0.0
.bss 32833 32833 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 624824 624824 0 0.0
.dynamic 560 560 0 0.0
.got 13552 13552 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 457580 457580 0 0.0
.text 7736900 7736884 -16 -0.0
lighting-app debug+rpc (read only) 2564289 2564033 -256 -0.0
(read/write) 129888 129888 0 0.0
.bss 49632 49632 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72296 72296 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 214832 214800 -32 -0.0
.text 2179058 2178834 -224 -0.0
lock-app debug (read only) 2529281 2529041 -240 -0.0
(read/write) 124872 124872 0 0.0
.bss 48032 48032 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69272 69272 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 229936 229904 -32 -0.0
.text 2133746 2133538 -208 -0.0
ota-provider-app debug (read only) 2332865 2332657 -208 -0.0
(read/write) 118672 118672 0 0.0
.bss 47680 47680 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63256 63256 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 204728 204728 0 0.0
.text 1964930 1964722 -208 -0.0
ota-requestor-app debug (read only) 2451321 2451081 -240 -0.0
(read/write) 125576 125576 0 0.0
.bss 50016 50016 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67480 67480 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 208448 208416 -32 -0.0
.text 2071266 2071058 -208 -0.0
shell debug (read only) 2567161 2566905 -256 -0.0
(read/write) 141400 141400 0 0.0
.bss 57608 57608 0 0.0
.data 1248 1248 0 0.0
.data.rel.ro 76856 76856 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229042 229010 -32 -0.0
.text 2180562 2180338 -224 -0.0
thermostat-no-ble arm64 (read only) 2341052 2340764 -288 -0.0
(read/write) 141265 141249 -16 -0.0
.bss 55233 55233 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75616 75592 -24 -0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139444 139412 -32 -0.0
.text 1964768 1964544 -224 -0.0
tv-app debug (read only) 3114913 3114641 -272 -0.0
(read/write) 257024 257024 0 0.0
.bss 167064 167064 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 78792 78792 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 250440 250408 -32 -0.0
.text 2676050 2675810 -240 -0.0
tv-casting-app debug (read only) 5368625 5368385 -240 -0.0
(read/write) 158328 158328 0 0.0
.bss 51256 51256 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98352 98352 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 334625 334593 -32 -0.0
.text 4767474 4767266 -208 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2448968 2448936 -32 -0.0
.bss 214444 214444 0 0.0
.data 5872 5872 0 0.0
.text 1411612 1411580 -32 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176959 1176887 -72 -0.0
bss 143068 143068 0 0.0
rodata 142440 142416 -24 -0.0
text 812580 812540 -40 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157011 1156939 -72 -0.0
bss 142304 142304 0 0.0
rodata 133972 133948 -24 -0.0
text 801892 801852 -40 -0.0
p6 all-clusters-app default (read only) 881632 881632 0 0.0
(read/write) 1686564 1686492 -72 -0.0
.bss 149064 149064 0 0.0
.data 2648 2648 0 0.0
.text 1526464 1526392 -72 -0.0
all-clusters-minimal-app default (read only) 882352 882352 0 0.0
(read/write) 1630684 1630604 -80 -0.0
.bss 148344 148344 0 0.0
.data 2648 2648 0 0.0
.text 1471304 1471224 -80 -0.0
light-app default (read only) 890656 890656 0 0.0
(read/write) 1550716 1550644 -72 -0.0
.bss 140248 140248 0 0.0
.data 2440 2440 0 0.0
.text 1399640 1399568 -72 -0.0
lock-app default (read only) 886184 886184 0 0.0
(read/write) 1588308 1588236 -72 -0.0
.bss 144704 144704 0 0.0
.data 2456 2456 0 0.0
.text 1432760 1432688 -72 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 799404 799328 -76 -0.0
bss 70744 70744 0 0.0
noinit 40416 40416 0 0.0
text 567128 567078 -50 -0.0
lighting-app tlsr9518adk80d (read/write) 819452 819376 -76 -0.0
bss 71588 71588 0 0.0
noinit 40416 40416 0 0.0
text 583672 583624 -48 -0.0

@woody-apple woody-apple merged commit e1f4dce into sve Jul 25, 2022
@woody-apple woody-apple deleted the cherry-pick-0629b6e0b790e92869f879f35aa1a7efd45ad7f1 branch July 25, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
sve cherry pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woody-apple @tcarmelveilleux